Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Fix linux-x64 AOT-llvm perf job #92644

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Sep 26, 2023

Based on the findings discussed in dotnet/performance#3338 Mono Linux x64 performance job wasn't doing AOT-llvm. In this PR we are adding /p:MonoAOTEnableLLVM=true and /p:MonoEnableLLVM=true build flags that are needed for Ubuntu x64 to do AOT with LLVM backend.

Additionally, we are adding mono-aot-cross --llvm --version command to the Helix job for future verification of enabled LLVM.

Changing llvm:false tag to llvm:true for x64 AOT Perf jobs. (Arm64 change will follow later for .NET 9)


cc: @kotlarmilos @directhex @LoopedBard3

@ghost
Copy link

ghost commented Sep 26, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on the findings discussed in dotnet/performance#3338 Mono Linux x64 performance job wasn't doing AOT-llvm. In this PR we are adding /p:MonoAOTEnableLLVM=true and /p:MonoEnableLLVM=true build flags that are needed for Ubuntu x64 to do AOT with LLVM backend.

Additionally, we are adding mono-aot-cross --llvm --version command to the script responsible for creating AOT directory for future verification of enabled LLVM.


cc: @kotlarmilos @directhex @LoopedBard3

Author: matouskozak
Assignees: matouskozak
Labels:

area-Infrastructure-mono

Milestone: -

@matouskozak matouskozak marked this pull request as ready for review September 26, 2023 13:50
@matouskozak matouskozak marked this pull request as draft September 27, 2023 10:06
@kotlarmilos kotlarmilos self-requested a review October 3, 2023 09:43
@matouskozak matouskozak marked this pull request as ready for review October 4, 2023 07:36
@matouskozak matouskozak merged commit 9476f40 into dotnet:main Oct 5, 2023
181 of 184 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
@matouskozak matouskozak deleted the fix-linux-x64-AOT-build branch October 3, 2024 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants