[release/8.0][wasm] Fix Vector128 SIMD fmin and fmax #93677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it propagates NaNs
ghost
assigned 
lewing
approved these changes
Oct 18, 2023
vargaz
approved these changes
Oct 18, 2023
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93556
Customer Impact
Customers on WebAssembly platforms using Vector128 min and max methods may see wrong results as the NaN values are not propagated.
Risk
Low
Change description
Fix #92885
Min and max now use NaN propagating SIMD instructions,
f32x4.min,f64x2.min,f32x4.maxandf64x2.max.Example emitted code:
for