Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub_93597 test build #93833

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix GitHub_93597 test build #93833

merged 1 commit into from
Oct 24, 2023

Conversation

gbalykov
Copy link
Member

Build error (at least with BuildAsStandalone=true)

BuildAsStandalone=true ./src/tests/build.sh -Release portablebuild=false -x64 -priority1
/home/runtime/src/tests/Loader/classloader/regressions/GitHub_93597/GitHub_93597.cs(8,27): error XUW1001: Projects in merged tests group should not have entry points. Convert to Facts or Theories. [/home/runtime/src/tests/Loader/classloader/regressions/GitHub_93597/GitHub_93597.csproj] [/home/runtime/src/tests/build.proj]

Related to #93616

cc @clamp03 @t-mustafin

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 22, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 22, 2023
@gbalykov
Copy link
Member Author

cc @lambdageek without this change tests build fails

@gbalykov
Copy link
Member Author

@lambdageek can this be merged?

@lambdageek lambdageek merged commit 10be4c0 into dotnet:main Oct 24, 2023
98 of 101 checks passed
@gbalykov
Copy link
Member Author

Thank you

@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@clamp03 clamp03 clamp03 approved these changes

Assignees

@gbalykov gbalykov

Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbalykov @lambdageek @clamp03