Avoid throwing when attempting to set IInternalModelingOnlyValue #94404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cctor interpreter represents some things that can only be used within the interpreter (but cannot be serialized to frozen blobs) as `IInternalModelingOnlyValue`. There was a piece of lazy code that was considering field assignments with these as invalid IL (we throw on invalid IL that we then catch later). Use the usual `Status.Fail` instead to reduce first chance exceptions. We don't want first chance exceptions in valid code.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThe cctor interpreter represents some things that can only be used within the interpreter (but cannot be serialized to frozen blobs) as Cc @dotnet/ilc-contrib
|
vitek-karas
approved these changes
Nov 6, 2023
This was referenced Nov 6, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cctor interpreter represents some things that can only be used within the interpreter (but cannot be serialized to frozen blobs) as
IInternalModelingOnlyValue. There was a piece of lazy code that was considering field assignments with these as invalid IL (we throw on invalid IL that we then catch later). Use the usualStatus.Failinstead to reduce first chance exceptions. We don't want first chance exceptions in valid code.Cc @dotnet/ilc-contrib