Implement HttpWebRequest AllowWriteStreamBuffering property #95001

liveans · 2023-11-20T12:51:37Z

This property is set (to TRUE or FALSE) in a 10.2% Nuget package that uses HttpWebRequest.

ghost · 2023-11-20T12:51:48Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	liveans
Assignees:	-
Labels:	`area-System.Net`
Milestone:	-

rzikm

Looks good so far.

src/libraries/System.Net.Requests/src/System/Net/HttpClientContentStream.cs

src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs

src/libraries/System.Net.Requests/src/System/Net/RequestStream.cs

…am-buffering-impl

liveans · 2023-12-15T14:06:29Z

/azp list

azure-pipelines · 2023-12-15T14:06:35Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-staging runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-android-grpc-client-tests runtime-wasm-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-tools-tests runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-nativeaot-outerloop

liveans · 2023-12-15T14:06:53Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-12-15T14:07:03Z

Azure Pipelines successfully started running 1 pipeline(s).

liveans · 2023-12-15T15:29:59Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-12-15T15:30:12Z

Azure Pipelines successfully started running 1 pipeline(s).

liveans · 2023-12-15T18:55:42Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2023-12-15T18:55:55Z

Azure Pipelines successfully started running 1 pipeline(s).

liveans · 2024-01-02T09:52:02Z

/azp run runtime-libraries-coreclr outerloop

…g stream to HttpClient Internal Stream directly

liveans · 2024-02-23T15:44:23Z

I've ended up removing StreamBuffer and separating the Non-Buffering and Buffering streams. Currently, the buffering mode will use ByteArrayContent again, and for streaming mode, we have RequestStreamContent which connects the internal HttpClient stream to RequestStream directly, and basically RequestStream becomes a wrapper as Natalia suggested in our chat.

Is there any pushback on these changes?

cc @ManickaP @MihaZupan @CarnaViire

src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs

liveans · 2024-02-23T16:23:36Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2024-02-23T16:23:45Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/System.Net.Requests/src/System/Net/RequestBufferingStream.cs

…ingStream.cs Co-authored-by: Anton Firszov <antonfir@gmail.com>

src/libraries/System.Net.Requests/src/System/Net/RequestStream.cs

liveans · 2024-02-29T16:38:46Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2024-02-29T16:39:00Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP

This looks good! Last batch of mostly small comments. Thanks!

src/libraries/System.Net.Requests/src/System/Net/RequestStream.cs

src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs

src/libraries/System.Net.Requests/src/System/Net/RequestBufferingStream.cs

src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs

liveans · 2024-03-04T14:26:06Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2024-03-04T14:26:17Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP

LGTM, thanks!

Implement HttpWebRequest WriteStreamBuffering

cf19c74

dotnet-issue-labeler bot added the area-System.Net label Nov 20, 2023

ghost assigned liveans Nov 20, 2023

rzikm reviewed Nov 20, 2023

View reviewed changes

build-analysis bot mentioned this pull request Nov 20, 2023

[6.0, 7.0, 8.0] Connection reset assert failure in System.Net.Sockets.Tests.SendReceive_SyncForceNonBlocking.TcpReceiveSendGetsCanceledByDispose #92423

Open

liveans added 10 commits December 4, 2023 16:12

Fix tests

6167c96

Fix tests

f1e9a29

Review feedback

5015280

Fix timeouts

b7c62d1

fix test build

9ae4383

Hang test

3114962

Merge branch 'main' of github.com:dotnet/runtime into http-write-stre…

266b610

…am-buffering-impl

Fix build

8e20ffa

fix tests

98152a2

delete unnecessary line

ff5e2bd

liveans added 2 commits December 15, 2023 17:57

fix tests

32832f7

refactor test

69f3da7

Dispose http client

dd0b860

build-analysis bot mentioned this pull request Dec 15, 2023

XUnitLogChecker: runtime-libraries-coreclr outerloop tests are unable to find the tool DLL #96035

Closed

Fix buffer write in RequestStream.Flush() method

31ef8a6

Seperate Buffering and Non-Buffering Streams and Connect non-bufferin…

dd1bdde

…g stream to HttpClient Internal Stream directly

liveans commented Feb 23, 2024

View reviewed changes

src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs Outdated Show resolved Hide resolved

liveans added 2 commits February 23, 2024 19:56

Remove unnecessary code in HttpWebRequestTest

c60f443

Merge branch 'main' into http-write-stream-buffering-impl

a699449

antonfirsov reviewed Feb 26, 2024

View reviewed changes

src/libraries/System.Net.Requests/src/System/Net/RequestBufferingStream.cs Outdated Show resolved Hide resolved

liveans and others added 3 commits February 26, 2024 22:33

Use random data for testing

dcac125

Update src/libraries/System.Net.Requests/src/System/Net/RequestBuffer…

c01da77

…ingStream.cs Co-authored-by: Anton Firszov <antonfir@gmail.com>

Merge branch 'main' into http-write-stream-buffering-impl

1b51e50

MihaZupan reviewed Feb 26, 2024

View reviewed changes

src/libraries/System.Net.Requests/src/System/Net/RequestStream.cs Outdated Show resolved Hide resolved

Remove default flushes and add flush on test

38656d5

build-analysis bot mentioned this pull request Feb 27, 2024

[browser][MT] WebSocket is already in CLOSING or CLOSED state #97260

Closed

Merge branch 'main' into http-write-stream-buffering-impl

796f1e9

ManickaP reviewed Mar 4, 2024

View reviewed changes

Review feedback

da86238

ManickaP approved these changes Mar 5, 2024

View reviewed changes

Removing unused code

804b80c

liveans merged commit 40bd270 into dotnet:main Mar 5, 2024
111 checks passed

github-actions bot locked and limited conversation to collaborators Apr 7, 2024

karelz added this to the 9.0.0 milestone May 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement HttpWebRequest AllowWriteStreamBuffering property #95001

Implement HttpWebRequest AllowWriteStreamBuffering property #95001

liveans commented Nov 20, 2023 •

edited

ghost commented Nov 20, 2023

rzikm left a comment

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Jan 2, 2024

liveans commented Feb 23, 2024

liveans commented Feb 23, 2024

azure-pipelines bot commented Feb 23, 2024

liveans commented Feb 29, 2024

azure-pipelines bot commented Feb 29, 2024

ManickaP left a comment

liveans commented Mar 4, 2024

azure-pipelines bot commented Mar 4, 2024

ManickaP left a comment

Implement HttpWebRequest AllowWriteStreamBuffering property #95001

Implement HttpWebRequest AllowWriteStreamBuffering property #95001

Conversation

liveans commented Nov 20, 2023 • edited

ghost commented Nov 20, 2023

rzikm left a comment

Choose a reason for hiding this comment

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Dec 15, 2023

azure-pipelines bot commented Dec 15, 2023

liveans commented Jan 2, 2024

liveans commented Feb 23, 2024

liveans commented Feb 23, 2024

azure-pipelines bot commented Feb 23, 2024

liveans commented Feb 29, 2024

azure-pipelines bot commented Feb 29, 2024

ManickaP left a comment

Choose a reason for hiding this comment

liveans commented Mar 4, 2024

azure-pipelines bot commented Mar 4, 2024

ManickaP left a comment

Choose a reason for hiding this comment

liveans commented Nov 20, 2023 •

edited