Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize nextRefPosition #97169

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Initialize nextRefPosition #97169

merged 1 commit into from
Jan 19, 2024

Conversation

jkoritzinsky
Copy link
Member

Without this, LTCG + AddressSanitizer causes build failures on Windows.

See https://github.com/dotnet/runtime/pull/95758/checks?check_run_id=20629528147

Without this, LTCG + AddressSanitizer causes build failures on Windows.

See https://github.com/dotnet/runtime/pull/95758/checks?check_run_id=20629528147
@jkoritzinsky jkoritzinsky requested a review from a team January 18, 2024 18:59
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 18, 2024
@ghost ghost assigned jkoritzinsky Jan 18, 2024
@ghost
Copy link

ghost commented Jan 18, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Without this, LTCG + AddressSanitizer causes build failures on Windows.

See https://github.com/dotnet/runtime/pull/95758/checks?check_run_id=20629528147

Author: jkoritzinsky
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoritzinsky jkoritzinsky merged commit 6fe8ff2 into main Jan 19, 2024
127 of 129 checks passed
@jkoritzinsky jkoritzinsky deleted the jkoritzinsky-patch-1 branch January 19, 2024 00:31
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants