Simplify BigInteger.Multiply #98587
Merged
Simplify BigInteger.Multiply #98587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsIn my previous pull request #92208, I split BigIntegerCalculator.Multiply into two methods: MultiplyNearLength and MultiplyFarLength. The reason for this division is that BenchmarkBenchmarkSwitcher.FromAssembly(typeof(Tests).Assembly).Run(args);
public class Tests
{
public IEnumerable<object> GetMultiplyArgs()
{
Random random = new Random(227);
var lengths = new int[] { 1000, 10000, 100000, 1000000 };
for (int i = lengths.Length - 1; i >= 0; i--)
{
var largeBytes = MakeBytes(random, lengths[i]);
var large = new BigInteger(largeBytes, isUnsigned: true);
{
var smallBytes = MakeBytes(random, lengths[i] / 2);
var small = new BigInteger(smallBytes, isUnsigned: true);
yield return new Data($"{largeBytes.Length:D7}-{smallBytes.Length:D7}", large, small);
}
for (int j = i; j >= 0; j--)
{
var smallBytes = MakeBytes(random, lengths[j]);
var small = new BigInteger(smallBytes, isUnsigned: true);
yield return new Data($"{largeBytes.Length:D7}-{smallBytes.Length:D7}", large, small);
}
}
static byte[] MakeBytes(Random random, int length)
{
var bytes = new byte[length];
random.NextBytes(bytes);
return bytes;
}
}
public record Data(string Name, BigInteger Large, BigInteger Small)
{
public override string ToString() => Name;
}
[Benchmark]
[ArgumentsSource(nameof(GetMultiplyArgs))]
public BigInteger Multiply(Data data)
{
return data.Large * data.Small;
}
}
|
kzrnm
force-pushed
the
BigIntegerMultiplySlim
branch
from
80d294c
to
763ebdd
Compare
This was referenced Feb 17, 2024
kzrnm
force-pushed
the
BigIntegerMultiplySlim
branch
from
763ebdd
to
f7eaf3b
Compare
teo-tsirpanis
added
the
community-contribution
kzrnm
force-pushed
the
BigIntegerMultiplySlim
branch
from
f7eaf3b
to
7d4f903
Compare
kzrnm
force-pushed
the
BigIntegerMultiplySlim
branch
from
7d4f903
to
08ec62a
Compare
This was referenced Mar 19, 2024
kzrnm
force-pushed
the
BigIntegerMultiplySlim
branch
from
08ec62a
to
95c7edc
Compare
This was referenced Mar 23, 2024
kzrnm
force-pushed
the
BigIntegerMultiplySlim
branch
from
95c7edc
to
f085edc
Compare
tannergooding
approved these changes
May 10, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous pull request #92208, I split BigIntegerCalculator.Multiply into two methods: MultiplyNearLength and MultiplyFarLength.
However, this division resulted in a lot of code duplication.
The reason for this division is that
coreLengthcan be greater thanbits.Length - n. Actually,core.Slice(0, ActualLength(core))seems to be sufficient sinceActualLength(core))is never greater thanbits.Length - n.https://github.com/kzrnm/dotnet-runtime/blob/f7eaf3b17fb4bd753b3404f0c9977c9693a2b480/src/libraries/System.Runtime.Numerics/src/System/Numerics/BigIntegerCalculator.SquMul.cs#L282-L326
Benchmark