JIT: Remove remaining BBJ_COND fallthrough fixups #99271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsPart of #93020. The diffs from this seem manageable locally -- my hope is the diffs in profile data up to block layout that drive this churn improve as we continue to propagate edge likelihoods to later phases.
|
This was referenced Mar 5, 2024
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs show small regressions all over the place, though they don't seem to manifest too often. Are we ok living with these, if it means we get to say we don't have any implicit fallthrough (except when restoring it before block layout)? |
AndyAyersMS
approved these changes
Mar 5, 2024
51 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #93020. The diffs from this seem manageable locally -- my hope is the diffs in profile data up to block layout that drive this churn improve as we continue to propagate edge likelihoods to later phases.