add Pack=false on implicit framework references in sdk for projects targeting net framework

[rohit21agrawal]

NuGet just checked in a feature to start packing framework assemblies NuGet/NuGet.Client#1361 (written down as frameworkAssemblyReferences in the nuspec of the resulting nupkg) . It allows one to override this behavior by specifying Pack=false on a Reference to prevent it from being packed.

Sdk targets should mark all the implicit references with Pack=false so they don't get packed by default.

[natemcmaster]

Question about expected behavior: will this also filter implicit framework references added from PackageReference?

e.g.:
System.Collections/4.3.0 contains

    <frameworkAssemblies>
      <frameworkAssembly assemblyName="System" targetFramework=".NETFramework4.5" />
      <frameworkAssembly assemblyName="System.Core" targetFramework=".NETFramework4.5" />
    </frameworkAssemblies>

If I am making a project that references this, should these also be hoisted to my nuspec if my project looks like this?

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net46</TargetFramework>
  </PropertyGroup>
   <ItemGroup>
    <PackageReference Include="System.Collections" Version="4.3.0" />
  </ItemGroup>
</Project>

cc @emgarten

[davidfowl]

If I am making a project that references this, should these also be hoisted to my nuspec if my project looks like this?

No, it shouldn't be hoisted. Nothing gets transitively hoisted like this on pack in nuget. Framework assemblies aren't special.

Transitive hosting happens at consumption time, not pack time.

[natemcmaster]

Transitive hosting happens at consumption time, not pack time.

Ok. This feature may need more work then. I'm currently seeing these references being hoisted into the nuspec.

[livarcocc]

I believe this work needs to happen in NuGet though. What this work was tracking was explicitly marking the implicit framework references that the SDK added as Pack=false.

@rohit21agrawal can you take a look?