Skip to content

VB-specific DocumentationFile generation. #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2018
Merged

VB-specific DocumentationFile generation. #1848

merged 1 commit into from
Jan 11, 2018

Conversation

dasMulli
Copy link
Contributor

@dasMulli dasMulli commented Jan 9, 2018

Fixes #1598

VB targets already include $(IntermediateOutputPath), so don't add it for GenerateDocumentationFile.

@dasMulli dasMulli force-pushed the bugfix/generate-doc-vb branch from c7e2884 to 4a87981 Compare January 9, 2018 03:00
@dasMulli
Copy link
Contributor Author

dasMulli commented Jan 9, 2018

cc @nguerrera @livarcocc

This changes
screen shot 2018-01-09 at 02 45 32

to

screen shot 2018-01-09 at 02 46 22

@dasMulli dasMulli mentioned this pull request Jan 9, 2018
Closed
@livarcocc livarcocc added this to the 2.2.0 milestone Jan 9, 2018
peterhuene
peterhuene approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that $(AssemblyName) is a path for VB alone, but +1.

@nguerrera nguerrera merged commit 753207c into dotnet:master Jan 11, 2018
@dasMulli dasMulli mentioned this pull request Jun 22, 2018
Closed
@dsplaisted dsplaisted mentioned this pull request Jun 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@nguerrera nguerrera nguerrera approved these changes

@livarcocc livarcocc livarcocc approved these changes

@peterhuene peterhuene peterhuene approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.3xx

Development

Successfully merging this pull request may close these issues.

4 participants

@dasMulli @nguerrera @livarcocc @peterhuene