Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn-analyzers #29911

Merged
merged 6 commits into from
Jan 17, 2023
Merged

[main] Update dependencies from dotnet/roslyn-analyzers #29911

merged 6 commits into from
Jan 17, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 12, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 7373e65e-2472-4105-649a-08d8e9757c68
  • Build: 20230117.1
  • Date Produced: January 17, 2023 1:31:52 PM UTC
  • Commit: 22ea6422f85b05ca0793cc3b76375487be407f5d
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
d2b4a0a 
…uild 20230112.1

Microsoft.SourceBuild.Intermediate.roslyn-analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.4-beta1.23059.1 -> To Version 3.3.4-beta1.23062.1
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/roslyn-analyzers:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/roslyn-analyzers) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
7e02161 
…uild 20230112.2

Microsoft.SourceBuild.Intermediate.roslyn-analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.4-beta1.23059.1 -> To Version 3.3.4-beta1.23062.2
@nagilson
Copy link
Member

This doesn't appear to be a transient thing. Waiting for the Roslyn team to take a look.

@mavasani
Copy link
Contributor

Working on a fix with #29906

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
79be234 
…uild 20230113.1

Microsoft.SourceBuild.Intermediate.roslyn-analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.4-beta1.23059.1 -> To Version 3.3.4-beta1.23063.1
This was referenced Jan 13, 2023
Merged
Merged
@mavasani
Update GenerateLayout.targets
e00442e 
React to package structure updates in dotnet/roslyn-analyzers#6325 and dotnet/roslyn-analyzers#6427 to generate props/targets/config files in `buildtransitive` folder
@mavasani mavasani mentioned this pull request Jan 16, 2023
Closed
@mavasani
Copy link
Contributor

Tagging @jmarolf

I am unable to figure out why the Ubuntu checks are failing, when it succeeds fine for Windows and Mac. The targets/props flagged as missing are indeed present inside the buildtransitive folder in the NuGet package: https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8/NuGet/Microsoft.CodeAnalysis.NetAnalyzers/overview/8.0.0-preview1.23063.1

ViktorHofer added a commit to ViktorHofer/roslyn-analyzers that referenced this pull request Jan 17, 2023
@ViktorHofer
Fix buildtransitive vs buildTransitive difference
9018071 
NuGet expects build files that should be transitively applied to a consuming project to be in a folder called "buildTransitive". dotnet@afee469 moved config files into that folder but the change had a typo as it specified "buildtransitive" instead of "buildTransitive". That resulted in a mismatch during pack time.

Fixes dependency update in dotnet/sdk#29911
@ViktorHofer ViktorHofer mentioned this pull request Jan 17, 2023
Merged
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 17, 2023 •
edited
Loading

@mavasani your issue will be fixed with dotnet/roslyn-analyzers#6436

The targets/props flagged as missing are indeed present inside the buildtransitive folder in the NuGet package:

They are present in the buildTransitive folder, not buildtransitive. buildtransitive isn't a naming convention that NuGet understands.

image

@mavasani
Copy link
Contributor

Thanks @ViktorHofer. I presume we will need to bump the package version and sha once the NuGet package with your fix gets published?

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 17, 2023 •
edited
Loading

That will happen automatically by Maestro. I will take care of anything that's left.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
46e9f01 
…uild 20230117.1

Microsoft.SourceBuild.Intermediate.roslyn-analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.3.4-beta1.23059.1 -> To Version 3.3.4-beta1.23067.1
@dotnet-maestro dotnet-maestro bot merged commit ee5bbf7 into main Jan 17, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-449e38f0-b741-4af6-b607-28292e4a4351 branch January 17, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nagilson @mavasani @ViktorHofer