[Experiment] Add ability to manage Local SDKs in the SDK #49209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, so we were going to make a bootstrapper that was standalone and could be invoked from the sdk. We started that in the cli-lab repo. Then budget cuts, layoffs, and office politics made it so we decided to put it into the SDK. Then we decided to use the existing code instead of taking the time to write all new code. The point of this will be to have install and uninstall / local sdk management from the sdk itself for things like ci runners, making it easy to manage a local sdk or initialize a repo to download the sdk specified in a global json, etc. All I am doing in this commit is copying everything from DNVM when it was MIT license as approved by the owner. That is step 1. If you review this all you need to check is that I copied the src folder correctly. Idk how you mess that up. Step 2 would be getting it to build. Step 3 will be taking out the parts we dont need such as serde. I am just copying it all so you can review it but none of this will be used by the SDK until later.
I am trying to make this simple and we can add them back later once we figure out how to do it with the first few
Caveats: Need to make sure zio, semver, and spectre.console is source buildable (iirc spectre already is)
|
I think this is a bad approach. You can't just 'remove' serde. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.