Skip to content

Simplify run properties usage #50391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Simplify run properties usage #50391

merged 1 commit into from
Aug 20, 2025

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Aug 20, 2025 •
edited
Loading

Addressing #49991 (comment).

@jjonescz jjonescz mentioned this pull request Aug 20, 2025
Merged
@jjonescz jjonescz marked this pull request as ready for review August 20, 2025 15:53
@Copilot Copilot AI review requested due to automatic review settings August 20, 2025 15:53
Copilot
Copilot AI reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the usage of run properties by accessing them directly from the runProperties object rather than using the project.GetPropertyValue() method. This change improves code consistency and readability by utilizing properties that are already available in the runProperties parameter.

  • Replaced two project.GetPropertyValue() calls with direct property access from runProperties

@jjonescz jjonescz merged commit cbc871d into dotnet:main Aug 20, 2025
29 checks passed
@jjonescz jjonescz deleted the run-properties branch August 20, 2025 15:53
@baronfel
Copy link
Member

@jjonescz do you want this for 10.x? if so a backport to release/10.0.1xx is necessary

@Youssef1313
Copy link
Member

If it was originally a perf issue, I think it's best to have in 10.x.

@baronfel Is main now for .NET 11? We then need to make sure all our future dotnet test PRs are backported as well. cc @mariam-abdulla @nohwnd

@baronfel
Copy link
Member

@Youssef1313 yes, it is. I've just created a pinned issue and I'm working on a github actions workflow to raise a comment on any main-targeting PR for the near future reminding contributors of this.

@Youssef1313
Copy link
Member

/backport to release/10.0.1xx

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/17121860183

@github-actions github-actions bot mentioned this pull request Aug 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjonescz @baronfel @Youssef1313