Cleanup dotnet test for MTP #50552
Merged
Cleanup dotnet test for MTP #50552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
dev/ygerges/dotnet-test-cleanup
branch
from
52c819a to
0bb0f5a
Compare
nohwnd
reviewed
Sep 1, 2025
| } | ||
| catch (Exception ex) | ||
| { | ||
| // TODO: it might be better idea to let this exception bubble to |
There was a problem hiding this comment.
@mariam-abdulla, what Youssef proposes sounds like a much better way to handle this. Do you agree and can you implement it?
There was a problem hiding this comment.
This shouldn't cause crashing or failing of the whole dotnet process.
We can discuss this.
There was a problem hiding this comment.
That's what FailFast does, but we can discuss for sure.
There was a problem hiding this comment.
Meanwhile, can we get this merged and follow-up on this later? @nohwnd @mariam-abdulla
| if (RuntimeInformation.RuntimeIdentifier.Contains("ios") || | ||
| RuntimeInformation.RuntimeIdentifier.Contains("android")) | ||
| { | ||
| return; |
There was a problem hiding this comment.
is this handled automatically in the new code?
There was a problem hiding this comment.
@nohwnd I don't think .NET CLI runs on android/ios AFAIK. For MTP, the reason this code existed for MTP is:
nohwnd
approved these changes
Sep 1, 2025
mariam-abdulla
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.