Remove dnx.ps1 #51120
Open
Remove dnx.ps1 #51120
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
approved these changes
Oct 3, 2025
|
/ba-g GenerateBundle known issue |
|
This LGTM but we need to get Tactics approval |
|
@dotnet/dotnet-docker-admin this PR would remove the |
It's easy to remove it. dotnet-docker's PR validation should fail whenever the change flows in, at which point we can just revert the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #51067. The .ps1 script prevents the CLI from correctly processing
--. So we'll remove the script, This will regress to the "terminate batch job" behavior described in #49623, but that's better than incorrectly processing command line arguments.Description
Removes dnx.ps1 helper script.
Customer impact
Fixes processing of
--when calling dnx from PowerShell.Brings back "Terminate Batch Job" prompt when CTRL+C is pressed, but this is preferrable to incorrectly processing the command line.
Regression
dnxis new in .NET 10. This was a regression from a previous preview release.Risk
Low