Include instructions for multi-targeting #51121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Copilot CLI locally to make speculative changes to the sdk. The CLI was able to detect when multi-targeting was needed to access new .NET Core APIs but it defaulted to emitting `#if NET6_0_OR_GREATER`. Looking at the build files our minimum TFM is, likely, `net9.0` hence this is unnecessary. Considered for a bit adding an instruction that told copilot what the minimum TFM was but in the end decided that the preference would almost always be `#if NET` anyways hence just default to that. Tested before / after locally this change resulted a better experience.
|
@baronfel PTAL |
|
This PR is targeting |
There was a problem hiding this comment.
Pull Request Overview
This PR adds guidance for conditional compilation directives to improve the developer experience when using Copilot CLI for multi-targeting scenarios. The change addresses an issue where Copilot was defaulting to overly specific target framework conditionals like #if NET6_0_OR_GREATER when the simpler #if NET would be more appropriate for this codebase.
- Added instruction to use
#if NETfor .NET Core specific code and#if NETFRAMEWORKfor .NET Framework specific code
baronfel
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Copilot CLI locally to make speculative changes to the sdk. The CLI was able to detect when multi-targeting was needed to access new .NET Core APIs but it defaulted to emitting
#if NET6_0_OR_GREATER. Looking at the build files our minimum TFM is, likely,net9.0hence this is unnecessary.Considered for a bit adding an instruction that told copilot what the minimum TFM was but in the end decided that the preference would almost always be
#if NETanyways hence just default to that.Tested before / after locally this change resulted a better experience.