[8.0/9.0] License scan tests failing due to scancode CLI TypeError

[ellahathaway]

Failing pipeline run

License scan tests are failing on the 8/9 branches for every repo being scanned. The error occurs during execution of scancode.

Error Message:

System.InvalidOperationException : Failed to execute scancode --license --processes 4 --timeout 300 --strip-root --only-findings --ignore *.ildump --json-pp /mnt/vss/_work/1/s/artifacts/TestResults/Release/scancode-results.json /mnt/vss/_work/1/s/src/<repo>/
Exit code: 1
Traceback (most recent call last):
  File "/tmp/scancode-env/bin/scancode", line 5, in <module>
    from scancode.cli import scancode
  File "/tmp/scancode-env/lib/python3.10/site-packages/scancode/cli.py", line 383, in <module>
    def scancode(
  File "/tmp/scancode-env/lib/python3.10/site-packages/click/decorators.py", line 374, in decorator
    _param_memo(f, cls(param_decls, **attrs))
  File "/tmp/scancode-env/lib/python3.10/site-packages/commoncode/cliutils.py", line 454, in __init__
    super(PluggableCommandLineOption, self).__init__(
  File "/tmp/scancode-env/lib/python3.10/site-packages/click/core.py", line 2793, in __init__
    raise TypeError("Secondary flag is not valid for non-boolean flag.")
TypeError: Secondary flag is not valid for non-boolean flag.

[mthalman]

I suspect this is a regression caused by an updated version of the click Python package. We had a similar issue in the past where an upgrade to click caused a break in scancode: #5159. Looking at the failing build, I see it's installing version 8.3.0 of click while the previous successful run installed version 8.2.2.