Force corefx to build identity and runtime packages #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've submitted PR's to fix the release/2.1 branches: |
|
@weshaggard @dseefeld Can you give some more detail about what this fixes? Where are the CoreFX identity packages used? Edit: Nevermind, picked up what this is about from standup. Packages aren't being built in the online build, so we end up with all of CoreFX as prebuilt. The tarball build does create the packages, but it's uncertain whether they take over cleanly from the prebuilts (and we don't want the prebuilts in there regardless). |
|
@dotnet-bot test Debian8.4 Release |
dseefeld
approved these changes
May 1, 2018
dagood
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dseefeld this should fix the issue you are seeing with corefx not publishing packages.
Looks like when we tried to fix the corefx/coreclr package builds we based it off the wrong property.
dotnet/corefx#28607
dotnet/coreclr#17323
In those PR's we based it on DotNetBuildOffline but that is only set in the tarball not the source-build. We should instead update corefx and coreclr to use DotNetBuildFromSource for these conditions. I will submit a PR to change them.
Note that I'm only workaround the corefx in this PR because we don't actually use the identity packages from coreclr in our other builds.