Skip to content

Add tasks for poisoning and checking for poison in packages. #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2018
Merged

Add tasks for poisoning and checking for poison in packages. #797

merged 3 commits into from
Oct 13, 2018

Conversation

crummel
Copy link
Contributor

@crummel crummel commented Oct 1, 2018

Still having some build errors locally, so I want to see what this does on all legs.

@crummel
Copy link
Contributor Author

crummel commented Oct 2, 2018

@dagood and @dseefeld - this isn't completely ready yet, I'm still adding usage of the tasks to the build, but the tasks should be ready for a first look if you have time.

dagood
dagood reviewed Oct 2, 2018
View reviewed changes
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of code comments, surface-level. There are some too-long lines throughout, and the chopping is a bit weird to me in some places (I think chopping on an arbitrary , out of a few makes it harder to read, but I'm probably too picky on that).

@crummel crummel force-pushed the poisoning branch 3 times, most recently from 0f608d6 to 4cebc88 Compare October 10, 2018 17:16
@crummel crummel removed the no-merge label Oct 11, 2018
@crummel
Copy link
Contributor Author

crummel commented Oct 11, 2018

@dseefeld I think I've addressed most of Davis' comments if you want to take another look.

crummel
crummel commented Oct 11, 2018
View reviewed changes
crummel
crummel commented Oct 11, 2018
View reviewed changes
dseefeld
dseefeld reviewed Oct 11, 2018
View reviewed changes
@crummel
Copy link
Contributor Author

crummel commented Oct 13, 2018

@dotnet-bot test OSX10.12 Release please (java.nio.channels.ClosedChannelException)

@crummel crummel merged commit a5c9d9d into dotnet:release/2.1 Oct 13, 2018
@crummel crummel mentioned this pull request Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagood dagood dagood left review comments

+1 more reviewer

@dseefeld dseefeld dseefeld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crummel @dseefeld @dagood