Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show warning when deprecated command is used #4683

Merged
merged 1 commit into from
May 6, 2022
Merged

show warning when deprecated command is used #4683

merged 1 commit into from
May 6, 2022

Conversation

vlada-shubina
Copy link
Member

Problem

fixes #4260

Solution

Prints the error when deprecated syntax is used.

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@vlada-shubina
Copy link
Member Author

@baronfel could you please check the warning wording?
I'm still working on adapting tests

JanKrivanek
JanKrivanek approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

baronfel
baronfel approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message looks good to me, and I appreciate the uniform way you were able to define the deprecation message. Really happy to see this included.

src/Microsoft.TemplateEngine.Cli/Commands/BaseCommand.cs Outdated Show resolved Hide resolved
@vlada-shubina vlada-shubina marked this pull request as ready for review May 6, 2022 13:58
@vlada-shubina vlada-shubina requested a review from a team as a code owner May 6, 2022 13:58
@vlada-shubina vlada-shubina enabled auto-merge (rebase) May 6, 2022 15:18
@vlada-shubina vlada-shubina merged commit 3647451 into dotnet:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider showing a warning in case old dotnet new command syntax is used
3 participants
@vlada-shubina @baronfel @JanKrivanek