Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Razor 16.8 Preview 4 Release #4095

Merged
merged 7 commits into from
Sep 30, 2020
Merged

Razor 16.8 Preview 4 Release #4095

merged 7 commits into from
Sep 30, 2020

Conversation

TanayParikh
Copy link
Contributor

cc/ @NTaylorMullen @ajaybhargavb @ryanbrandenburg

TanayParikh
TanayParikh commented Sep 29, 2020
View reviewed changes
package.json
@@ -3155,6 +3155,54 @@
"env": {
"type": "object",
"description": "Environment variables passed to dotnet. Only valid for hosted apps."
},
"logging": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi/ @captainsafia

@codecov
Copy link

codecov bot commented Sep 29, 2020 •
edited
Loading

Codecov Report

Merging #4095 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4095   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1856     1856           
  Branches      214      214           
=======================================
  Hits         1596     1596           
  Misses        200      200           
  Partials       60       60
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7120374...847195c. Read the comment docs.

TanayParikh
TanayParikh commented Sep 29, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
NTaylorMullen
NTaylorMullen approved these changes Sep 29, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@TanayParikh @NTaylorMullen
Update CHANGELOG.md
847195c 
Co-authored-by: N. Taylor Mullen <nimullen@microsoft.com>
@TanayParikh
Copy link
Contributor Author

cc/ @JoeRobich

@JoeRobich JoeRobich merged commit 1b7e1b8 into dotnet:master Sep 30, 2020
@TanayParikh TanayParikh deleted the taparik/razor168Preview4 branch September 30, 2020 00:22
@TanayParikh
Copy link
Contributor Author

Thanks @JoeRobich! 🎉

@JoeRobich
Copy link
Member

@TanayParikh In case you didn't find it, I built a new prerelease with this change - https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.3-beta3

@TanayParikh
Copy link
Contributor Author

@TanayParikh In case you didn't find it, I built a new prerelease with this change - https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.3-beta3

Thanks!

This was referenced Oct 21, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia left review comments

@NTaylorMullen NTaylorMullen NTaylorMullen approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TanayParikh @JoeRobich @captainsafia @NTaylorMullen