-
Notifications
You must be signed in to change notification settings - Fork 723
Bump Razor #7940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Razor #7940
Conversation
* Don't create overlapping changes when doing additional formatting (#11413) (PR: [#11413](https://github.com/dotnet/razor/pull/11413)) | ||
* Synchronize razor compiler assembly loading (#11394) (PR: [#11394](https://github.com/dotnet/razor/pull/11394)) | ||
* Allow generate method to handle delegates (#11402) (PR: [#11402](https://github.com/dotnet/razor/pull/11402)) | ||
* Fix bad completion commit in vs code (#11398) (PR: [#11398](https://github.com/dotnet/razor/pull/11398)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that issue says "There will be a corresponding PR in VS Code to actually pass the new flag.". Should I hold off merging, or remove that line item from the change log, until that happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is no longer true from https://github.com/dotnet/razor/pull/11398/files#r1924384742
Previously it would have needed a change to pass the flag in. The cat was away though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right. In case it wasn't clear how little attention I was paying, even though I may have appeared to be, I am glad to now cement this knowledge :)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Mainly to bring in dotnet/razor#11413 and fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2347107
View Complete Diff of Changes