Skip to content

Conversation

davidwengier
Copy link
Member

@davidwengier davidwengier commented Jan 24, 2025

@davidwengier davidwengier requested a review from a team January 24, 2025 05:50
@davidwengier davidwengier requested a review from a team as a code owner January 24, 2025 05:50
* Don't create overlapping changes when doing additional formatting (#11413) (PR: [#11413](https://github.com/dotnet/razor/pull/11413))
* Synchronize razor compiler assembly loading (#11394) (PR: [#11394](https://github.com/dotnet/razor/pull/11394))
* Allow generate method to handle delegates (#11402) (PR: [#11402](https://github.com/dotnet/razor/pull/11402))
* Fix bad completion commit in vs code (#11398) (PR: [#11398](https://github.com/dotnet/razor/pull/11398))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that issue says "There will be a corresponding PR in VS Code to actually pass the new flag.". Should I hold off merging, or remove that line item from the change log, until that happens?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is no longer true from https://github.com/dotnet/razor/pull/11398/files#r1924384742

Previously it would have needed a change to pass the flag in. The cat was away though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right. In case it wasn't clear how little attention I was paying, even though I may have appeared to be, I am glad to now cement this knowledge :)

@davidwengier
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dibarbet dibarbet merged commit d2cf5de into dotnet:main Feb 4, 2025
14 of 16 checks passed
@davidwengier davidwengier deleted the BumpRazor branch February 5, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants