-
Notifications
You must be signed in to change notification settings - Fork 727
Add copilot setup steps #8655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copilot setup steps #8655
Conversation
70308e4
to
0073d71
Compare
# Install .NET SDK (required for some build components and MSBuild tasks) | ||
- uses: actions/setup-dotnet@v4 | ||
with: | ||
dotnet-version: '8.0.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8? Should we not do later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're on 8 for general restore/signing/integration tests at the moment - https://github.com/dotnet/vscode-csharp/blob/main/azure-pipelines/dotnet-variables.yml
Probably works with 10, but would rather match rest of CI.
|
||
# Install gulp globally (required for build tasks) | ||
- name: Install gulp | ||
run: npm install -g gulp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about vsce?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And gulp installDependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on installDependencies, should be doing that if it wants to run integration tests (though I don't expect them to run well on these machines without additional changes). vsce I suppose could potentially be useful if it wants to package something, but that is a pretty rare workflow. Can add it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we give it the ability to grab the latest roslyn and its dependencies as well? Would it need that to be able to integrate new roslyn APIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grabbing prebuilt Roslyn bits is difficult, since we'd have to cross over to dnceng/internal to figure out which builds we should use, and would need permissions to pull them from the right upstream.
Potentially it could instead just checkout Roslyn and build it here, but going to punt on that for now - want to get the most basic scenario working first.
No description provided.