Skip to content

Conversation

dibarbet
Copy link
Member

No description provided.

@dibarbet dibarbet marked this pull request as ready for review September 25, 2025 23:36
@dibarbet dibarbet requested a review from a team as a code owner September 25, 2025 23:36
@dibarbet dibarbet requested a review from 333fred September 25, 2025 23:36
# Install .NET SDK (required for some build components and MSBuild tasks)
- uses: actions/setup-dotnet@v4
with:
dotnet-version: '8.0.x'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8? Should we not do later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're on 8 for general restore/signing/integration tests at the moment - https://github.com/dotnet/vscode-csharp/blob/main/azure-pipelines/dotnet-variables.yml

Probably works with 10, but would rather match rest of CI.


# Install gulp globally (required for build tasks)
- name: Install gulp
run: npm install -g gulp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about vsce?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And gulp installDependencies?

Copy link
Member Author

@dibarbet dibarbet Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on installDependencies, should be doing that if it wants to run integration tests (though I don't expect them to run well on these machines without additional changes). vsce I suppose could potentially be useful if it wants to package something, but that is a pretty rare workflow. Can add it anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we give it the ability to grab the latest roslyn and its dependencies as well? Would it need that to be able to integrate new roslyn APIs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabbing prebuilt Roslyn bits is difficult, since we'd have to cross over to dnceng/internal to figure out which builds we should use, and would need permissions to pull them from the right upstream.

Potentially it could instead just checkout Roslyn and build it here, but going to punt on that for now - want to get the most basic scenario working first.

@dibarbet dibarbet merged commit 84826a6 into dotnet:main Sep 26, 2025
3 checks passed
@dibarbet dibarbet deleted the copilot_setup_steps branch September 26, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants