Fixing of the DataGridViewComboBoxColumn in "Nothing" display mode #6081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de when the DisplayStyle property is set to Nothing. dotnet#1587 Since the ComboBox in the "Nothing" display style and view mode is displayed as a normal cell, a condition was added so that for this case it would return the "DataItem" control type instead of the "ComboBox" control type. Support for the "CollapseExpand" pattern is also disabled for this case
RussKie
approved these changes
Oct 28, 2021
RussKie
deleted the
Issue-1587_DataGridViewComboBoxColumn_DisplayStyle_Nothing
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1587
Proposed changes
ComboBoxin theNothingdisplay style and view mode is displayed as a normal cell, a condition was added so that for this case it would return theDataItemcontrol type instead of theComboBoxcontrol type. Support for theExpandCollapsepattern is also disabled for this caseCustomer Impact
Before fix:
After fix:
Regression?
Risk
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow