Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker has incorrect AccessKey and KeyboardShortcut accessibility properties when Text contains '&' character #9414

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Jul 3, 2023

Fixes #9281

Proposed changes

  • fix DateTimePicker's KeyboardShortcut property
  • add unit tests

Regression?

  • No

Screenshots

Before

image

After

image

Test methodology

  • Manually and Unit Test

Test environment(s)

8.0.0-preview.7.23330.6

Microsoft Reviewers: Open in CodeFlow

…sibility properties when Text contains '&' character dotnet#9281
@ghost ghost assigned Epica3055 Jul 3, 2023
@ghost ghost added the draft draft PR label Jul 3, 2023
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Jul 3, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 4, 2023
@Epica3055 Epica3055 marked this pull request as ready for review July 4, 2023 06:33
@Epica3055 Epica3055 requested a review from a team as a code owner July 4, 2023 06:33
@ghost ghost removed the draft draft PR label Jul 4, 2023
@dreddy-work dreddy-work merged commit f7dd99e into dotnet:main Jul 5, 2023
@ghost ghost added this to the 8.0 Preview7 milestone Jul 5, 2023
@Epica3055 Epica3055 deleted the Issue_9281_DateTimePicker_has_incorrect_AccessKey_and_KeyboardShortcut_accessibility_properties_when_Text_contains_&_character branch July 10, 2023 08:58
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants