[StyleCleanUp] Use compound assignment (IDE0054) #10620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
I wonder why that one doesn't trigger an error during compilation since its warning level. But I guess IDE0074's suggestion overrides that. Or maybe since both IDE0054 and IDE0074 fall under this. Line 94 in b6914d7 Anyways, LGTM though I firmly believe some simply hurt readibility in pursuit of shorter line haha. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10620 +/- ##
===================================================
+ Coverage 10.95887% 11.21257% +0.25370%
===================================================
Files 3310 3310
Lines 664667 664665 -2
Branches 74667 74667
===================================================
+ Hits 72840 74526 +1686
+ Misses 590685 588907 -1778
- Partials 1142 1232 +90
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dipeshmsft
previously approved these changes
Mar 28, 2025
himgoyalmicro
added
Included in test pass
Status:InProgress
Status:Committed
and removed
Queue for test pass
labels
jizc
force-pushed
the
style-clean-up/ide0054
branch
from
0010ddc to
d73f0c0
Compare
dipeshmsft
approved these changes
Apr 7, 2025
|
Thanks @jizc for your contribution. |
|
Thank you for merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10619
Description
Fixes all
IDE0054warnings by switching to compound assignment. All changes were automated, with the exception of restoring comments inPopup.cs, and the removal of redundant braces (second commit).Customer Impact
Cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
None.
Microsoft Reviewers: Open in CodeFlow