Skip to content

Fix: reordered import in temporary project to ensure correct property… #11151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Fix: reordered import in temporary project to ensure correct property… #11151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...c/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/GenerateTemporaryTargetAssembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,6 @@ private bool ExecuteGenerateTemporaryTargetAssemblyWithPackageReferenceSupport()
// Add Analyzers to Analyzer item list.
AddNewItems(xmlProjectDoc, AnalyzerTypeName, Analyzers);

// Replace implicit SDK imports with explicit SDK imports
ReplaceImplicitImports(xmlProjectDoc);

// Add properties required for temporary assembly compilation
var properties = new List<(string PropertyName, string PropertyValue)>
{
Expand All @@ -283,6 +280,10 @@ private bool ExecuteGenerateTemporaryTargetAssemblyWithPackageReferenceSupport()

AddNewProperties(xmlProjectDoc, properties);

// Replace implicit SDK imports with explicit SDK imports
// In this temorary project file, the SDK import must be inserted before the added PropertyGroup.
ReplaceImplicitImports(xmlProjectDoc);

// Save the xmlDocument content into the temporary project file.
xmlProjectDoc.Save(TemporaryTargetAssemblyProjectName);

Expand Down