Fix GetEntryAssemblyLocation Uri #4799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
We do not escape the path string in GetEntryAssemblyLocation method. And it will break when the application in the special path, such as the path contains a `#`. See dotnet#4781
lindexi
force-pushed
the
t/lindexi/FixGetContentStream
branch
from
baeac4e to
5867dc7
Compare
|
Is similar fix needed for when |
Sorry, it seems hard to create the assembly with the name contains |
anjaligupta-dev
approved these changes
Jul 13, 2021
|
@anjalisheel-wpf Thank you. And any news? |
singhashish-wpf
approved these changes
Jul 23, 2021
ryalanms
added a commit
that referenced
this pull request
Aug 4, 2021
lindexi
added a commit
to dotnet-campus/wpf
that referenced
this pull request
Aug 12, 2021
The Application.ResourceAssembly.CodeBase is the string without escaped. See: - dotnet#4781 - dotnet#5004 - dotnet#4799
lindexi
added a commit
to dotnet-campus/wpf
that referenced
this pull request
Aug 12, 2021
The Application.ResourceAssembly.CodeBase is the string without escaped. See: - dotnet#4781 - dotnet#5004 - dotnet#4799
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #4781
Description
We do not escape the path string in GetEntryAssemblyLocation method. And it will break when the application in the special path, such as the path contains a
#. See #4781Customer Impact
All the GetContentStream
Regression
No.
Testing
Just CI
Risk