LOC CHECKIN | dotnet/wpf master | 20190618 #999
Conversation
ghost
requested review from
|
Hello @vatsan-madhavan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot, require at least 1 sign off. |
|
@msftbot, require approvals from any one of the following: @vatsan-madhavan, @rladuca, @SamBent, @stevenbrix, @ryalanms |
|
@msftbot, require signoff from @ryalanms |
This reverts commit 9a10af9.
|
@ryalanms , msftbot did something strange here and merged the PR before the rules were satisfied. Would you mind taking a look to ensure all is well with this PR? |
| <trans-unit id="LocalizedControlTypeHyperlink"> | ||
| <source>hyperlink</source> | ||
| <target state="translated">hipervínculo</target> | ||
| <target state="translated">hyperlink</target> |
There was a problem hiding this comment.
LocalizedControlType* strings are used to register control types for UI Automation. These strings should be localized.
| <trans-unit id="LocalizedControlTypeHyperlink"> | ||
| <source>hyperlink</source> | ||
| <target state="translated">lien hypertexte</target> | ||
| <target state="translated">hyperlink</target> |
There was a problem hiding this comment.
All LocalizedControlType* strings should remain localized for all languages. Please review LocalizedControlTypeTable as well.
| <trans-unit id="LocalizedControlTypeTreeView"> | ||
| <source>tree view</source> | ||
| <target state="translated">visualizzazione albero</target> | ||
| <target state="translated">tree view</target> |
| <trans-unit id="LocalizedControlTypeImage"> | ||
| <source>image</source> | ||
| <target state="translated">イメージ</target> | ||
| <target state="translated">image</target> |
| <trans-unit id="LocalizedControlTypeHyperlink"> | ||
| <source>hyperlink</source> | ||
| <target state="translated">超链接</target> | ||
| <target state="translated">hyperlink</target> |
There was a problem hiding this comment.
The three that I see are hyperlink, image, and table. These should remain localized. Thanks.
ghost
locked as resolved and limited conversation to collaborators
No description provided.