Skip to content

Conversation

Rwing
Copy link
Contributor

@Rwing Rwing commented May 5, 2019

Maybe it's a breaking change?

@catcherwong
Copy link
Member

@Rwing LGTM, could you please change the target branch to dev?

@Rwing Rwing changed the base branch from master to dev May 5, 2019 10:44
@Rwing
Copy link
Contributor Author

Rwing commented May 5, 2019

I have changed.

@catcherwong catcherwong merged commit b376b64 into dotnetcore:dev May 5, 2019
@catcherwong
Copy link
Member

@Rwing Merged! Thanks for your PR! 😄

@Rwing
Copy link
Contributor Author

Rwing commented May 5, 2019

It's a breaking change, you'd better remind user.😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants