Skip to content

Allow to cache nulls #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 1, 2020
Merged

Allow to cache nulls #223

merged 11 commits into from
Oct 1, 2020

Conversation

Youkai-no-nii-chan
Copy link
Contributor

@Youkai-no-nii-chan Youkai-no-nii-chan marked this pull request as draft June 19, 2020 15:24
@Youkai-no-nii-chan Youkai-no-nii-chan marked this pull request as ready for review September 28, 2020 11:20
@Youkai-no-nii-chan
Copy link
Contributor Author

Only two flacky unrelated tests failed. Not sure is it worth to fix them in this PR.

@Youkai-no-nii-chan Youkai-no-nii-chan mentioned this pull request Sep 28, 2020
Closed
@catcherwong
Copy link
Member

Thanks, I will take a look ASAP.

@catcherwong catcherwong self-requested a review September 30, 2020 00:27
catcherwong
catcherwong reviewed Sep 30, 2020
View reviewed changes
Copy link
Member

@catcherwong catcherwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catcherwong
Copy link
Member

Could you please change the target branch from master to dev?

@Youkai-no-nii-chan Youkai-no-nii-chan changed the base branch from master to dev October 1, 2020 10:11
@Youkai-no-nii-chan
Copy link
Contributor Author

Could you please change the target branch from master to dev?

Done

@catcherwong catcherwong merged commit e597cd5 into dotnetcore:dev Oct 1, 2020
@catcherwong
Copy link
Member

Release version 1.1.0-alpha20201001103202 for this PR.

If there is no feedback in the near future, we will release a stable version. Thank you very much!! 😄

@Youkai-no-nii-chan Youkai-no-nii-chan deleted the CacheNulls branch October 4, 2020 08:37
@catcherwong catcherwong mentioned this pull request May 31, 2021
Closed
vla added a commit to vla/EasyCaching that referenced this pull request Jun 2, 2021
@vla
fix: CSRedisCachingProvider设置CacheNulls=true导致GetAsync永远返回CacheValue.…
634b4b9 
…Null dotnetcore#223

* dataRetriever返回非空时候导致默认反序列化出现空对象异常
* dataRetriever返回非空时候不应该返回CacheValue.Null

Closes dotnetcore#307
@vla vla mentioned this pull request Jun 2, 2021
Merged
@catcherwong catcherwong mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catcherwong catcherwong catcherwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youkai-no-nii-chan @catcherwong