fix: Do not toggle dropwdown on pill removal #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchief
reviewed
Aug 1, 2018
src/tag/index.js
Outdated
| <span className={cx('tag')}> | ||
| {label} | ||
| <button onClick={this.handleClick} className={cx('tag-remove')} type="button"> | ||
| <button onClick={e => this.handleClick(e)} className={cx('tag-remove')} type="button"> |
There was a problem hiding this comment.
This can be simply onClick={this.handleClick} (avoids creating a function on every render). I wonder why linting didn't flag this.
There was a problem hiding this comment.
Okay. I'll update it.
| handleClick = e => { | ||
| const { id, onDelete } = this.props | ||
|
|
||
| e.stopPropagation() |
There was a problem hiding this comment.
Don't remember why but I think we also need to add e.stopImmediatePropagation() too.
There was a problem hiding this comment.
Right. We can use stopImmediatePropagation() because it implicitly calls stopPropagation(). I'll update the code.
mrchief
changed the title
priyanshu92
added a commit
to priyanshu92/react-dropdown-tree-select
that referenced
this pull request
Aug 3, 2018
fix: Do not toggle dropwdown on pill removal (dowjones#141) 🐛
mrchief
added a commit
that referenced
this pull request
Aug 14, 2018
mrchief
added a commit
that referenced
this pull request
Aug 14, 2018
mrchief
added a commit
that referenced
this pull request
Aug 14, 2018
mrchief
pushed a commit
that referenced
this pull request
Sep 16, 2018
fix: Do not toggle dropwdown on pill removal
mrchief
pushed a commit
that referenced
this pull request
Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Prevents the dropdown from toggling again and again when the selected tags are removed.