Skip to content

remove react as dependency and add as dev dependency #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2017
Merged

remove react as dependency and add as dev dependency #21

merged 2 commits into from
Nov 5, 2017

Conversation

jvgomg
Copy link
Contributor

@jvgomg jvgomg commented Nov 5, 2017

Should help prevent apps consuming this component from loading multiple version of React.

#19

@coveralls
Copy link

coveralls commented Nov 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 58ed10c on jvgreenaway:peer-dependancies into ff694d3 on dowjones:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db46ef5 on jvgreenaway:peer-dependancies into ff694d3 on dowjones:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db46ef5 on jvgreenaway:peer-dependancies into ff694d3 on dowjones:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db46ef5 on jvgreenaway:peer-dependancies into ff694d3 on dowjones:master.

@mrchief mrchief merged commit c634c82 into dowjones:master Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mrchief mrchief mrchief approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvgomg @coveralls @mrchief