Null check for non existing childre to not write aria-expanded false … #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so that screen readers do not read that the level is closed
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| attributes['aria-checked'] = partial ? 'mixed' : checked | ||
| attributes['aria-level'] = (_depth || 0) + 1 | ||
| attributes['aria-expanded'] = _children && (expanded ? 'true' : 'false') | ||
| _children !== undefined && _children.length > 0 |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
|
Code Climate has analyzed commit 6c801ee and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Pull Request Test Coverage Report for Build 1499
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…so that screen readers do not read that the level is closed
What does it do?
Null check for children of certain level to not write out "aria-expanded=false" since screen readers reads the level to be closed when there is no children beneath the current parent.
Fixes # (issue)
No recorded issue.
Type of change
Checklist: