unescaped double quote in searchdata.js breaks search box functionality (Origin: bugzilla #792727) #6316
Description
status ASSIGNED severity normal in component general for ---
Reported in version 1.8.15-GIT on platform Other
Assigned to: Dimitri van Heesch
On 2018-01-20 14:18:55 +0000, Dan Cruthirds wrote:
javascript breaks when the double quote is part of the list of characters,
as the double quote needs to be escaped (or the whole string surrounded by
single quotes instead of double).
Code snippet from searchdata.js :
var indexSectionsWithContent =
{
0: ""_abcdefghijklmnopqrstuvwxyz~",
1: "abcdefghilmnoprstuvxy",
2: "adirs",
3: "abcdefghilmnpqrstuw",
4: "_abcdefghilmnopqrstuvwxz~",
5: ""abcdefghijklmnopqrstuvwxyz",
6: "acdefghijklmnprsuvwz",
7: "bcdefghilmoprst",
8: "abcdefghilmnopqrstuvwxz",
9: "o",
10: "_abcdefghilmnoprstuvwxyz",
11: "abcdt"
};
Entries 0: and 5: need the double quote escaped, so it looks like this:
var indexSectionsWithContent =
{
0: "\"_abcdefghijklmnopqrstuvwxyz~",
1: "abcdefghilmnoprstuvxy",
2: "adirs",
3: "abcdefghilmnpqrstuw",
4: "_abcdefghilmnopqrstuvwxz~",
5: "\"abcdefghijklmnopqrstuvwxyz",
6: "acdefghijklmnprsuvwz",
7: "bcdefghilmoprst",
8: "abcdefghilmnopqrstuvwxz",
9: "o",
10: "_abcdefghilmnoprstuvwxyz",
11: "abcdt"
};
On 2018-01-21 08:34:16 +0000, albert wrote:
Can you please attach a self contained example (source+config file in a tar
or zip) that allows us to reproduce the problem?
On 2018-02-04 13:20:40 +0000, albert wrote:
I just pushed the indicated change to github (pull request 650).
I've not been able to create an example myself regarding the problem, so an
example is still highly appreciated!
On 2018-02-10 13:59:19 +0000, albert wrote:
Patch has been integrated into main development branch on github.