Skip to content

Conversation

albert-github
Copy link
Collaborator

@albert-github albert-github commented Mar 13, 2021

In the ACE TAO project we see a lot of warnings like:

.../ACE_TAO/ACE/html/libtao-doc/TAO.tag:1: error: Internal inconsistency: namespace in IDL not module, library or constant group

the line number 1 is here incorrect and should be 54613, 55152 or 55345.
The reason is that the real line number is not stored although it is available from the xml reader

(the reason for the warning is another issue and should be handled separately)

In the ACE TAO project we see a lot of warnings ;ike:
```
.../ACE_TAO/ACE/html/libtao-doc/TAO.tag:1: error: Internal inconsistency: namespace in IDL not module, library or constant group
```
the line number 1 is here incorrect and should be 54613, 55152 or 55345.
The reason is that the real line number is not stored although it is available from the xml reader

(the reason for the warning is another issue and should be handled separately)
@doxygen
Copy link
Owner

doxygen commented Apr 27, 2021

Hi Albert, can you attach the tag file that gives this error? I'd like to reproduce the problem and try to solve it using XMLLocator instead of passing an extra lineNr parameter.

@albert-github
Copy link
Collaborator Author

I've made a small example showing the problem (artificial, based on the actual TAO code but a bit smaller).
In the old version we see

tst.tag:1: error: Internal inconsistency: namespace in IDL not module, library or constant group

though this is the incorrect line and should be (as it is in the corrected version):

tst.tag:28: error: Internal inconsistency: namespace in IDL not module, library or constant group

Example: example.tar.gz

doxygen added a commit that referenced this pull request Apr 28, 2021
@doxygen
Copy link
Owner

doxygen commented Apr 28, 2021

@albert-github I've just pushed a slightly adapted implementation using the m_locator object for the line number (see 0b6a075 ).
Please verify that it works the same as your proposal.

@albert-github
Copy link
Collaborator Author

Looks OK to me and is a bit simpler as now the info is available at the "source.

Wouldn't it be better to initialize the int linenr (e.g. to -1 or 0) in the tagreader.cpp` at the lines 93 and 108.

@albert-github albert-github added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Apr 29, 2021
@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants