Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cas #968

Closed
wants to merge 16 commits into from
Closed

Support cas #968

wants to merge 16 commits into from

Conversation

sumous
Copy link

@sumous sumous commented Apr 29, 2019

New, Add support for cas
issue is: #949

1.support for cas 3.0
2.Add examples for cas in examples/cas

@sumous
Copy link
Author

sumous commented Apr 30, 2019

email attribute has a unique constraint, it should be email=username + '@email.notfound'
Refer: #965

@dpgaspar
Copy link
Owner

Can you please add some tests?

@sumous
Copy link
Author

sumous commented May 22, 2019

Can you please add some tests?

I am developing. Tests are added.
I'll add docs later.

@sumous sumous changed the title Support cas [WIP]Support cas May 22, 2019
@sumous sumous changed the title [WIP]Support cas Support cas May 22, 2019
@sumous sumous marked this pull request as ready for review May 22, 2019 15:16
@sumous
Copy link
Author

sumous commented May 23, 2019

@dpgaspar all done.

@stale
Copy link

stale bot commented Aug 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

@stale stale bot added stale and removed stale labels Aug 21, 2019
Copy link

@nakkasyamprasad nakkasyamprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NA

@ganesh8614
Copy link

New, Add support for cas
issue is: #949

1.support for cas 3.0
2.Add examples for cas in examples/cas

Hello,

Have followed the provided configurations and able to route the Apache Superset URL (http) to CAS URL(https), but getting unauthorized service exception in browser.

Because my CAS service is configured HTTPS with SSL enable (with certificates) and Superset is running without https/ssl, due to this getting unauthorized exception.

Could you please provide the steps to work superset with HTTPS/SSL.

@nakkasyamprasad
Copy link

New, Add support for cas
issue is: #949

1.support for cas 3.0
2.Add examples for cas in examples/cas

Hello,

After done the provided changes able to route the Apache Superset URL to CAS Login page, once CAS got authenticated getting below error in browser.

Could you please provide your inputs on the issue.

Browser URL: https://hostname:port/login/?ticket=ST-17-I2V2g5Qw1hQWYfCGW2YVEtz1voYcasHostName

500 - Internal Server Error
Stacktrace

    Traceback (most recent call last):

File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask_appbuilder/security/views.py", line 776, in login
userinfo = self.validateUser(session[cas_token_session_key])
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask_appbuilder/security/views.py", line 837, in validateUser
attributes = xml_from_dict["cas:attributes"]
KeyError: 'cas:attributes'

Regards,
Syam

@nakkasyamprasad
Copy link

New, Add support for cas
issue is: #949
1.support for cas 3.0
2.Add examples for cas in examples/cas

Hello,

After done the provided changes able to route the Apache Superset URL to CAS Login page, once CAS got authenticated getting below error in browser.

Could you please provide your inputs on the issue.

Browser URL: https://hostname:port/login/?ticket=ST-17-I2V2g5Qw1hQWYfCGW2YVEtz1voYcasHostName

500 - Internal Server Error
Stacktrace

    Traceback (most recent call last):

File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask_appbuilder/security/views.py", line 776, in login
userinfo = self.validateUser(session[cas_token_session_key])
File "/obi/ApacheSuperset/venv/lib/python3.6/site-packages/flask_appbuilder/security/views.py", line 837, in validateUser
attributes = xml_from_dict["cas:attributes"]
KeyError: 'cas:attributes'

Regards,
Syam

Any inputs on this issue will be appreciated.

Regards,
Syam

@stale
Copy link

stale bot commented Nov 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

@stale stale bot added the stale label Nov 28, 2019
@stale stale bot closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants