Update group.partitions_for_topic to fetch topic metadata if it does … #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
requested changes
May 20, 2019
kafka/consumer/group.py
Outdated
|
|
||
| Returns: | ||
| set: topics | ||
| def _fetch_all_topic_metadata(self): |
There was a problem hiding this comment.
Is the Java client structured this way with this private method?
It's a nice clean way to do it this way, but just curious how they handle it...
There was a problem hiding this comment.
Yep! I think that's what I based it on https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L1892
Baisang
force-pushed
the
baisang/partitions_for_topic
branch
from
097a7c0
to
1878cc0
Compare
|
@jeffwidman Thanks for the feedback -- I addressed your comments, hopefully travis is kind to me. |
jeffwidman
approved these changes
May 23, 2019
|
🎆 Thanks again for this! |
ghost
mentioned this pull request
Baisang
added a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 27, 2019
If the cluster metadata object has no info about the topic, then issue a blocking metadata call to fetch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…not have it
As mentioned in #1774, this attempts to simulate the Java client, which does the following
https://kafka.apache.org/10/javadoc/index.html?org/apache/kafka/clients/producer/KafkaProducer.html#partitionsFor
This change is