Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initialization order in KafkaClient #2119

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Fix initialization order in KafkaClient #2119

merged 3 commits into from
Sep 17, 2020

Conversation

pecalleja
Copy link
Contributor

@pecalleja pecalleja commented Sep 5, 2020 •
edited by dpkp
Loading

this resolve #2118

This change is Reviewable

jeffwidman
jeffwidman approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although could you add a comment? It'd be all too easy for this problem to creep back in later from someone who doesn't realize the order matters for these specific attributes...

kafka/client_async.py Show resolved Hide resolved
jeffwidman
jeffwidman reviewed Sep 17, 2020
View reviewed changes
kafka/client_async.py Outdated Show resolved Hide resolved
jeffwidman
jeffwidman reviewed Sep 17, 2020
View reviewed changes
kafka/client_async.py Outdated Show resolved Hide resolved
jeffwidman
jeffwidman reviewed Sep 17, 2020
View reviewed changes
kafka/client_async.py Outdated Show resolved Hide resolved
@jeffwidman jeffwidman merged commit e485a6e into dpkp:master Sep 17, 2020
@pecalleja pecalleja deleted the development branch September 17, 2020 16:13
gabriel-tincu pushed a commit to aiven/kafka-python that referenced this pull request Sep 22, 2020
@pecalleja
Fix initialization order in KafkaClient (dpkp#2119)
b3ea70c 
Fix initialization order in KafkaClient
chandlernine pushed a commit to layer9ai/kafka-python that referenced this pull request Jun 9, 2021
@pecalleja @chandlernine
Fix initialization order in KafkaClient (dpkp#2119)
df8f4ff 
Fix initialization order in KafkaClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird error after bad producer initialization
2 participants
@pecalleja @jeffwidman