MultiProcessConsumer: an option to use current offsets #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts fixed: kafka/consumer/simple.py
|
I think there's a better approach to this -- see #356 . I cherry-picked your test commits :) |
|
#356 merged w/ your tests included -- thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's continuation of #252 (fixes #173) with a small additional fix and a couple of base tests. This is an annoyance that so far current
MultiProcessConsumerstarts from 0 offsets each time, I braced myself the courage to finish it. The only moment here - I'm not sure about correct beautiful names for options, probably someone have a better idea.