Bug in module connect

[ghost]

Module connect implicitly creates ports using the module names when two modules are connected. This is fine when a module is connected to another one only once. The bug appears when many modules with the same name are connected to each other. Instead of creating a new port for every module, the old one just gets overwritten with the same name. To see this for example, try connecting every droplet together in run_droplet_a.py.

[dealmeidavf]

I added a note on usage to avoid the problem.

cortix/cortix/src/network.py

Lines 83 to 114 in 765e0cb

	def connect(self, module_port_a, module_port_b, info=None):
	'''Connect two modules using either their ports directly or inferred ports.
	A connection always opens a channel for data communication in both ways.
	That is, both sends and receives are allowed.
	Note
	----
	The simplest form of usage is with arguments: (`module_a`, `module_b`).
	In this case, a `port` with the name of `module_a` **must** exist in `module_b`,
	and vice-versa (port names as `str` in lower case). In addition, the connect
	must not be called again with these same two modules, else the underlying
	connection will be overriden.
	For more rigorous connection, the user is advised to fully specify the
	module and the port in each list argument.
	Parameters
	----------
	module_port_a: list([Module,Port]) or list([Module,str]) or Module
	First `module`-`port` to connect.
	module_port_b: list([Module,Port]) or list([Module,str]) or Module
	Second `module`-`port` to connect.
	info: str
	Information on the directionality of the information flow. This is for
	graph visualization purposes only. The default value will use the order
	in the argument list to define the direction. Default: None. If set
	to `bidiretional`, will create a double headed arrow in the graph figure.
	'''

[dealmeidavf]

I renamed the run_droplet_b.py to run_droplet_test.py because this is an older version we don't want to invest and because it is probably a good use for a CI test. Both options of network are running:

However there is something about DataPlot that does not share the data with the main process (multiprocessing option). Maybe look at this later...help appreciated.

[dealmeidavf]

Please post a fix when the pickled modules are loaded correctly. Refer this Issue number so we close this. Thanks.