Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for additional color choices #8

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

KyleJamesWalker
Copy link
Contributor

Updating with the additional colors that are available within the latest version of slack.

The screenshot could also be updated, but I only have it work so I can't update the screenshot.

@JimmyMultani
Copy link
Contributor

Hey @KyleJamesWalker, sorry for the late response.

I will check this out later tonight.

@JimmyMultani
Copy link
Contributor

Hey @zenorocha, I don't have write access for this repo. Could we get this merged in please?

@JimmyMultani
Copy link
Contributor

Hey again @zenorocha, could you please take a look at this when you get a chance?

@JimmyMultani
Copy link
Contributor

Friendly ping to @heinst, @quagliato or @zenorocha.

Can we get this looked at please? If we're lacking maintainers, I can volunteer.

@quagliato
Copy link
Member

quagliato commented May 29, 2021

Friendly ping to @heinst, @quagliato or @zenorocha.

Can we get this looked at please? If we're lacking maintainers, I can volunteer.

@JimmyMultani Hey, sorry for the delay. The notification about it got lost in my inbox. I'll check it later today and I'll update the screenshot also.
About volunteering as a maintainer, maybe @zenorocha can give you the right permissions. :)

@quagliato
Copy link
Member

@JimmyMultani @KyleJamesWalker Hey! I was reviewing this PR few minutes ago and I noticed that it changes the mention badge color from red to orange.
I just tested this new option and I really don't like the orange badge with the white number in it:
Screen Shot 2021-05-30 at 16 25 30
Maybe we should use this PR just to add the colors to the new 3 options, keep the mention badge in red and discuss the change from red to orange in a new PR. WDYT?

@JimmyMultani
Copy link
Contributor

Hey @quagliato, I think that's a fine idea!

@KyleJamesWalker, do you have time to update this PR? If not, we can address it ourselves.

@KyleJamesWalker
Copy link
Contributor Author

Yeah I can take a look at the badge color shortly.

@KyleJamesWalker
Copy link
Contributor Author

KyleJamesWalker commented May 30, 2021

@quagliato are you sure you have the values from this PR?

Here's what it looks like for me:
image

And here's what it looks like for a mention counter
image

EDIT: Sorry I changed that locally on my setup, let me update it to what I've had for a while locally.

@quagliato quagliato merged commit c66204a into dracula:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants