-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for additional color choices #8
Conversation
Hey @KyleJamesWalker, sorry for the late response. I will check this out later tonight. |
Hey @zenorocha, I don't have write access for this repo. Could we get this merged in please? |
Hey again @zenorocha, could you please take a look at this when you get a chance? |
Friendly ping to @heinst, @quagliato or @zenorocha. Can we get this looked at please? If we're lacking maintainers, I can volunteer. |
@JimmyMultani Hey, sorry for the delay. The notification about it got lost in my inbox. I'll check it later today and I'll update the screenshot also. |
@JimmyMultani @KyleJamesWalker Hey! I was reviewing this PR few minutes ago and I noticed that it changes the mention badge color from red to orange. |
Hey @quagliato, I think that's a fine idea! @KyleJamesWalker, do you have time to update this PR? If not, we can address it ourselves. |
Yeah I can take a look at the badge color shortly. |
@quagliato Here's what it looks like for me: And here's what it looks like for a mention counter EDIT: Sorry I changed that locally on my setup, let me update it to what I've had for a while locally. |
Updating with the additional colors that are available within the latest version of slack.
The screenshot could also be updated, but I only have it work so I can't update the screenshot.