Fix stack overflow parsing failure #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__tests__/VJsonParserTests.res
Outdated
Comment on lines
148
to
160
| test("long string value", () => { | ||
| let longValue = "pzqtdxvnhzvmzzigsojovukwfssmzadolomslufahgjbuininzcexwrkvnncmktcqpdcsrcnerdjrwgcncswsoovrrplikznwfqbvmrkeequwohejmrdmwmfcdkkfwhmqqiqgpfpelmhutdpshonwbtkxmwfoccaqogmzulumtcywyplotpbsldrampwwtmjwsmfhnnzumyhpyforahmivaalkhrenxxvnhuwpovjnkdjbrxvhobpmffinjtuaegkqejfxfejiatxkpxvxboftretjleyxysfwlkiyjfdnvhjdtsopwuvznzpzrzvntiixdqifzsiktwhvgimwpgsgxrbczqhnycsalycgcngilyjwlxkhmaieffcpfptwzqffrlwpksmjbndftkjkjcnwqgbfwoucguujltbcfkerbwrsoeofdmmawmzlegojrujqbkftagqarwbvrlmsgwyxhpcxrdyynjrbltvrtiruhbsmroovmgqfgvogrjshjbhzgucsmavrnyuxqwaqpjhlrqargmuoixwnorvepyvtybqbjrjzyafgzwxedpyezprhtbfzrcmpysfirgemwihpzlmciehdlolhrszfqnserejqqwsazshizvyuuagitooleocilvlfmoriwzpudhqdcngayfyyptuggzloyamzxtrekqeegawxjddprqkrwepeynqifacltgbxsmpqinpaegwkuvbawuuimculerazmttvvqptbyjmnsxrpiwtkqitsoljjqgfsghckooyzdqxeagckeqmmnkpmxqsgvqvbuhlwzgumrslhyvtegfaosnbfgmqdpbkgipiequsjgyopmbiwhvuryzknwayxedhiimqqnddlzgaxbklsvwjigjqltzitphlzguzgljzvylilltqystjnbyafopkanphhuntwbffnslweajomjvgzpkcjznwpnyliymimrfvcdcbcjgwmjdpmlfjiqhizk" | ||
| let rawText = ` | ||
| { | ||
| "query": "${longValue}", | ||
| "variables": { | ||
| "searchTerm": "bag", | ||
| "sortBy" : {{sortBy}}, | ||
| } | ||
| }` | ||
| expectOkParse(rawText, Object([("variables", Object([("searchTerm", String("bag")), ("sortBy", Variable("sortBy"))]->JsMap.fromArray)),("query", String(longValue))]->JsMap.fromArray)) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This is the added test
src/VJsonParse.res
Outdated
Comment on lines
28
to
40
| let escapedQuoteRegex = %re(`/\\\\"/gm`) | ||
| let inQuotes = %re(`/"(?:[^"\\\\]|\\\\.)*"/gm`) | ||
| // Parse a string. Allows for escaped quotes. | ||
| // NOTE: not to be confused with `parse`, which takes a raw string and parses | ||
| // a whole AST -- this parses string literal syntax. | ||
| let parseString: t<string> = | ||
| regex(inQuotes) | ||
| |> map(match => { | ||
| match | ||
| ->Js.String2.substring(~from=1, ~to_=match->Js.String2.length - 1) // Remove quotes from start and end | ||
| ->Js.String2.replaceByRe(escapedQuoteRegex, `"`) | ||
| }) | ||
| |> lexeme |
There was a problem hiding this comment.
This is the updated parser
YoussefHenna
changed the title
adnelson
commented
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.resinstead of.re. I'll add comments to highlight what changed, since most of the diff is file renaming