This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
feature: add client stream writer for Streaming #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found this is your first time to contribute to Dragonfly, @jim3ma |
jim3ma
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1186 +/- ##
=========================================
- Coverage 47.61% 47.51% -0.1%
=========================================
Files 115 116 +1
Lines 7254 7370 +116
=========================================
+ Hits 3454 3502 +48
- Misses 3523 3585 +62
- Partials 277 283 +6
Continue to review full report at Codecov.
|
Signed-off-by: 楚贤 <chuxian.mjj@antfin.com>
jim3ma
force-pushed
the
add-client-stream-writer
branch
from
0441b22
to
3c375d4
Compare
lowzj
reviewed
Jan 17, 2020
starnop
reviewed
Jan 19, 2020
jim3ma
force-pushed
the
add-client-stream-writer
branch
from
dc9ea6a
to
728d5f3
Compare
starnop
reviewed
Jan 19, 2020
jim3ma
force-pushed
the
add-client-stream-writer
branch
4 times, most recently
from
ec86192
to
7512a28
Compare
lowzj
reviewed
Jan 21, 2020
Signed-off-by: 楚贤 <chuxian.mjj@antfin.com>
Signed-off-by: 楚贤 <chuxian.mjj@antfin.com>
Signed-off-by: 楚贤 <chuxian.mjj@antfin.com>
jim3ma
force-pushed
the
add-client-stream-writer
branch
from
a144578
to
b40524a
Compare
starnop
reviewed
Feb 3, 2020
lowzj
reviewed
Feb 6, 2020
jim3ma
force-pushed
the
add-client-stream-writer
branch
from
5144878
to
6692474
Compare
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 楚贤 chuxian.mjj@antfin.com
Ⅰ. Describe what this PR did
Add
ClientStreamWriterto implement StreamingⅡ. Does this pull request fix one issue?
This PR is pre-commit for Proposal #1164
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews