Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #3

Open
luisitoalvarez opened this issue Nov 29, 2022 · 12 comments
Open

Improvements #3

luisitoalvarez opened this issue Nov 29, 2022 · 12 comments

Comments

@luisitoalvarez
Copy link

luisitoalvarez commented Nov 29, 2022

First improvement: graph view

Currently, in the graph view, you must place the cursor on the node for the link lines to be highlighted. Could I make them appear without needing to do this? That is, you can make them look like most themes or increase the color of the lines that connect to the nodes.

It is that not being able to see them becomes a bit tedious to know which nodes are linked to each other (attached screenshot)

ScreenShot

Second improvement: bold and italics

I think it would be good to be able to differentiate when the text is in bold or italics.

As they are currently confusing and the highlight function is not fulfilled (bold)

As a recommendation I could say that when the main color is: #ff475a, the bold text could be: #82aaff and vice versa, since it is the same color palette that the theme has, but I leave that to your choice (just like italicized text)

And another detail that I have noticed when using the theme these days is that it would be better if the title of each note was white and not red, I think it is a lot of red

These improvements would give the theme a better typing experience, it would be more comfortable and easy on the eyes, because it's kind of confusing right now:

Test

Third improvement

This might look good, but I wish you could change the color of the numbered list and the bulleted list. I think it could look much better with other colors to stand out from the normal text, now I think it looks a bit sad

Gray

@dragonwocky
Copy link
Owner

dragonwocky commented Dec 3, 2022

Currently, in the graph view, you must place the cursor on the node for the link lines to be highlighted. Could I make them appear without needing to do this? That is, you can make them look like most themes or increase the color of the lines that connect to the nodes.

Thanks for picking up on that, graph lines not being visible is fixed and released in v0.4.2.

As a recommendation I could say that when the main color is: #ff475a, the bold text could be: #82aaff and vice versa, since it is the same color palette that the theme has, but I leave that to your choice (just like italicized text)

Bold adds emphasis by increasing the weight of the font, italics add emphasis by increasing the slant of the font. Those are the formatting standards, I don't plan to change them. If you would like to change the colour of bold and italic text yourself anyway, you can add this to Obsidian Settings -> Appearance -> CSS snippets.

body.theme-dark,
body.is-mobile.theme-dark {
  --italic-color: var(--text-accent);
  --bold-color: var(--text-accent);
}

the highlight function is not fulfilled (bold)

Bold is not a "highlight function" - if you would like to highlight text in Obsidian you can format it ==like this==.
image

And another detail that I have noticed when using the theme these days is that it would be better if the title of each note was white and not red, I think it is a lot of red

I personally find that the accented titles and headings stand out nicely among the white of normal text, it helps break up content within the page so different paragraphs/sections are easy to find and separate. If you would prefer white headings, you can add this CSS snippet:

body.theme-dark,
body.is-mobile.theme-dark {
  --h1-color: var(--text-normal);
  --h2-color: var(--text-normal);
  --h3-color: var(--text-normal);
  --h4-color: var(--text-normal);
  --h5-color: var(--text-normal);
  --h6-color: var(--text-normal);
}

This might look good, but I wish you could change the color of the numbered list and the bulleted list. I think it could look much better with other colors to stand out from the normal text, now I think it looks a bit sad

Hmm, I'll have to think about this and do a bit more testing. I tried a couple of other colours but the theme's colours are mostly too bright and standout for colouring punctuation, so I'm not too sure about using any of them, and I'd rather not bloat the theme with extra colours beyond the base palette.

@luisitoalvarez
Copy link
Author

luisitoalvarez commented Dec 3, 2022

I personally find that the accented titles and headings stand out nicely among the white of normal text, it helps break up content within the page so different paragraphs/sections are easy to find and separate. If you would prefer white headings, you can add this CSS snippet:

body.theme-dark,
body.is-mobile.theme-dark {
  --h1-color: var(--text-normal);
  --h2-color: var(--text-normal);
  --h3-color: var(--text-normal);
  --h4-color: var(--text-normal);
  --h5-color: var(--text-normal);
  --h6-color: var(--text-normal);
}

Thank you very much for sharing the code with me, especially since I am not very good with programming and code.

Is there a way to be able to change the color of just the note title/name? I hope you can help me change it to white or maybe a custom color.

I'll add a screenshot so you know which one I mean:

IMG_1176

@dragonwocky
Copy link
Owner

Is there a way to be able to change the color of just the note title/name? I hope you can help me change it to white or maybe a custom color.

body.theme-dark,
body.is-mobile.theme-dark {
  --inline-title-color: var(--text-normal);
}

@luisitoalvarez
Copy link
Author

Thank you very much, friend for helping me and listening to me, also for the modifications, I can say that I am very comfortable with your theme.

Just one more question, will there be a snippet with which you can change the font of the text in the chart view? I would appreciate it very much if you would be so kind as to provide it to me.

It happens that there is a bug in version 1.0.3 for Windows, I already posted it on the forum, it is titled as
-Graph view should follow global “interface font”- so I wanted to see if you would be so kind as to fix it via a snippet while they fix it in the next update

@dragonwocky
Copy link
Owner

Just one more question, will there be a snippet with which you can change the font of the text in the chart view? I would appreciate it very much if you would be so kind as to provide it to me.

It happens that there is a bug in version 1.0.3 for Windows, I already posted it on the forum, it is titled as
-Graph view should follow global “interface font”- so I wanted to see if you would be so kind as to fix it via a snippet while they fix it in the next update

Unfortunately not, the graph view appears to be rendered as a canvas instead of as actual HTML, so I can't see a way to change the font with a simple snippet.

@luisitoalvarez
Copy link
Author

Thank you very much for your help my friend.

I don't know if it's a problem or you programmed it that way.

I comment that the embed text is usually lower than normal, which I consider looks a bit bad for both writing and reading.

I will attach two photos so you can see for yourself.

Could you help me with this? That is, I want it to be the same as the default version. Again, I would really appreciate it my friend.

Theme

Default

@dragonwocky
Copy link
Owner

I can't replicate this, the spacing looks the same to me?

image
image

If you send me the page it is happening on for you I can take a look.

@luisitoalvarez
Copy link
Author

How strange, I don't know why that proportion error doesn't appear to you.

I recorded a gif so you can see exactly what I mean. I haven't touched any of the code, so check with you.

bug

@dragonwocky
Copy link
Owner

@luisitoalvarez again, pictures don't help me... please send me the page file to test it on.

@luisitoalvarez
Copy link
Author

luisitoalvarez commented Dec 27, 2022

I was able to find where the bug is, I located what it is in these lines of code. I added all your code except these (the attached image) and it no longer gave the problem that I told you before.

Only that when doing this, now the icons of: minimize, maximize and close window that you customized have disappeared. I could see those lines and maybe find where the error is, as I mentioned I am not an expert in the code, I asked for help on discord and checking on my own I was able to reach that conclusion.

I hope you find it useful and that the error (the one with the embedded text space) can be corrected.

code

icons

@luisitoalvarez
Copy link
Author

@dragonwocky Hello friend again, I hope not to disturb you, that is not my intention. I have to clarify that I really like your topic and I feel very comfortable with it.

But sometimes I'm very picky about design, and that extra part of the embedded text bothers me a bit, I don't know if you could help me please with a code snippet where the default value is (embedded text)

I would really appreciate that help my friend.

@dragonwocky
Copy link
Owner

@luisitoalvarez I'll have a look at fixing this sometime soon, but I'm focusing on a couple of other projects at the moment, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants