Compare Z3 arrays by checking the formulas with the Z3 solver #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyroux
reviewed
Aug 22, 2019
wp/lib/bap_wp/src/constraint.ml
Outdated
| | Z3.Solver.UNKNOWN -> | ||
| failwith (Format.sprintf "get_refuted_goals: Unable to resolve branch \ | ||
| condition at %s" (Tid.to_string tid)) | ||
| end | ||
| | Clause (hyps, concs) -> | ||
| let hyps_false = List.exists hyps |
There was a problem hiding this comment.
Can't you pass all the hyp_vals in a big list to Z3.Solver.check, to only invoke it once? I think this is equivalent to the conjunction, which I think is what you want.
There was a problem hiding this comment.
Passing in the list of hyp_vals works like a charm!
codyroux
reviewed
Aug 22, 2019
| let mem = Var.create "mem" (mem32_t `r32) in | ||
| let loc1 = Var.create "loc" reg32_t in | ||
| let bv1 = Word.of_int ~width:32 0xDEADBEEF in | ||
| let bv2 = Word.of_int ~width:32 0x0FA1AFE1 in |
|
Looks fine to me except maybe that one line where you handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One caveat is that I had to change the API for
get_refuted_goalsfromt -> Z3.Model.model -> Z3.context -> goal Core_kernel.Sequence.ttot -> Z3.Solver.solver -> Z3.context -> goal Core_kernel.Sequence.t