End session with empty data packet if necessary. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add rake as development dependency so that `bundle exec rake` works as
expected.
- Remove descriptions from Rake::TestTasks object in order to avoid...
"undefined method `description=' for #<Rake::TestTask:..."
> The end of a transfer is marked by a DATA packet that contains > between 0 and 511 bytes of data (i.e., Datagram length < 516). -- [RFC 1350, Section 6: Normal Termination](https://www.ietf.org/rfc/rfc1350.txt)
|
Thanks again for contributing back! :) Much appreciated. Gem will be pushed. |
drbig
added a commit
that referenced
this pull request
Nov 19, 2015
End session with empty data packet if necessary.
|
Cool :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Piotr,
with this patch
tftpdwill properly terminate the session, even if the last data packet would have a payload of 512 bytes.Without the patch the session would timeout under such circumstances (10.1.1.1 = tftp client @ Cisco ASA, 10.1.1.100 = tftp server "fx-tftp"):
Now we just send an empty data packet and everybody is happy :-)
Thanks for pushing this to Rubygems as well,
Björn