Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add TypeScript type checking for localization files #1424

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Feb 27, 2024

  • I am sure that the code is update-to-date with the dev branch.

Copy link

github-actions bot commented Feb 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 31.54%. Comparing base (ccd30dc) to head (c97e673).

Files Patch % Lines
packages/docs-ui/src/locale/en-US.ts 0.00% 1 Missing ⚠️
packages/docs-ui/src/locale/zh-CN.ts 0.00% 1 Missing ⚠️
packages/find-replace/src/locale/en-US.ts 0.00% 1 Missing ⚠️
packages/find-replace/src/locale/zh-CN.ts 0.00% 1 Missing ⚠️
packages/sheets-numfmt/src/locale/en-US.ts 0.00% 1 Missing ⚠️
packages/sheets-numfmt/src/locale/zh-CN.ts 0.00% 1 Missing ⚠️
packages/sheets-ui/src/locale/zh-CN.ts 0.00% 1 Missing ⚠️
packages/sheets-zen-editor/src/locale/en-US.ts 0.00% 1 Missing ⚠️
packages/sheets-zen-editor/src/locale/zh-CN.ts 0.00% 1 Missing ⚠️
packages/ui/src/locale/en-US.ts 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1424      +/-   ##
==========================================
- Coverage   31.54%   31.54%   -0.01%     
==========================================
  Files         859      873      +14     
  Lines       48691    48705      +14     
  Branches    10070    10070              
==========================================
+ Hits        15359    15362       +3     
- Misses      33332    33343      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 4afe9e5 into dev Feb 27, 2024
7 checks passed
@jikkai jikkai deleted the feat/i18n branch February 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant