Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): formula select and negative #1444

Merged
merged 9 commits into from
Mar 7, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Feb 29, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1387
close #1415

@DR-Univer DR-Univer force-pushed the fix-formula-selection-and-negative branch from 52c5708 to 9317a5d Compare February 29, 2024 15:47
Copy link

github-actions bot commented Feb 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer requested a review from Jocs as a code owner February 29, 2024 15:51
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 75.21368% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 32.80%. Comparing base (b639394) to head (680ff4c).
Report is 7 commits behind head on dev.

Files Patch % Lines
...gine-formula/src/engine/ast-node/reference-node.ts 60.71% 11 Missing ⚠️
...-formula/src/engine/analysis/lexer-tree-builder.ts 87.50% 6 Missing ⚠️
...s/engine-formula/src/engine/utils/prefixHandler.ts 73.33% 4 Missing ⚠️
...ngine-formula/src/engine/ast-node/operator-node.ts 70.00% 3 Missing ⚠️
...ngine-formula/src/engine/ast-node/ast-root-node.ts 75.00% 1 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 0.00% 1 Missing ⚠️
...engine-formula/src/functions/meta/compare/index.ts 0.00% 1 Missing ⚠️
...engine-formula/src/functions/meta/divided/index.ts 0.00% 1 Missing ⚠️
...s/engine-formula/src/functions/meta/minus/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1444      +/-   ##
==========================================
+ Coverage   32.66%   32.80%   +0.13%     
==========================================
  Files         906      911       +5     
  Lines       50429    50616     +187     
  Branches    10509    10553      +44     
==========================================
+ Hits        16475    16605     +130     
- Misses      33954    34011      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer added the qa:untested This PR is ready to be tested label Mar 1, 2024
@zhaolixin7
Copy link

@DR-Univer 公式括号和计算符号组合计算错误
image

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@DR-Univer formula brackets and calculation symbol combination calculation error
image

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
@DR-Univer DR-Univer force-pushed the fix-formula-selection-and-negative branch from d8c23f6 to cf67270 Compare March 6, 2024 07:42
@DR-Univer DR-Univer added qa:untested This PR is ready to be tested and removed qa:rejected labels Mar 6, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 7, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 7, 2024
@DR-Univer DR-Univer merged commit 75de31c into dev Mar 7, 2024
7 checks passed
@DR-Univer DR-Univer deleted the fix-formula-selection-and-negative branch March 7, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
4 participants