Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets): filter #1465

Merged
merged 52 commits into from
Apr 25, 2024
Merged

feat(sheets): filter #1465

merged 52 commits into from
Apr 25, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 4, 2024

close #1450

@wzhudev wzhudev changed the title feat: sheet interceptor support row filtered feat: filter for sheet Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 65.60705% with 898 lines in your changes are missing coverage. Please review.

Project coverage is 31.04%. Comparing base (ddbeb02) to head (e7299e7).
Report is 4 commits behind head on dev.

Files Patch % Lines
...src/controllers/sheets-filter-render.controller.ts 0.00% 93 Missing ⚠️
...-filter/src/controllers/sheets-fiter.controller.ts 77.87% 79 Missing ⚠️
...filter-ui/src/views/widgets/filter-button.shape.ts 0.00% 56 Missing ⚠️
...-ui/src/controllers/sheets-filter-ui.controller.ts 0.00% 52 Missing ⚠️
...ets-ui/src/services/clipboard/clipboard.service.ts 64.80% 44 Missing ⚠️
...ter-ui/src/services/sheets-filter-panel.service.ts 84.03% 42 Missing ⚠️
...src/views/components/SheetsFilterPanel.stories.tsx 0.00% 42 Missing ⚠️
packages/sheets-filter/src/models/filter-model.ts 84.06% 40 Missing ⚠️
...views/components/SheetsFilterByConditionsPanel.tsx 0.00% 38 Missing ⚠️
...lter-ui/src/views/components/SheetsFilterPanel.tsx 0.00% 28 Missing ⚠️
... and 61 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1465      +/-   ##
==========================================
+ Coverage   29.71%   31.04%   +1.33%     
==========================================
  Files        1178     1208      +30     
  Lines       63983    66151    +2168     
  Branches    13590    13995     +405     
==========================================
+ Hits        19011    20537    +1526     
- Misses      44972    45614     +642     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev changed the title feat: filter for sheet feat(sheets): filter Mar 4, 2024
@wzhudev wzhudev force-pushed the wzhudev/feat-filter branch 7 times, most recently from 74217e8 to 102a94f Compare March 7, 2024 08:36
@wzhudev wzhudev force-pushed the wzhudev/feat-filter branch 17 times, most recently from ad9dd47 to 0f5ba5e Compare March 20, 2024 12:28
@wzhudev wzhudev force-pushed the wzhudev/feat-filter branch 2 times, most recently from dfa6e90 to 4517610 Compare March 25, 2024 11:15
@wzhudev wzhudev marked this pull request as ready for review April 25, 2024 08:41
@wzhudev wzhudev merged commit 1f03b7a into dev Apr 25, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/feat-filter branch April 25, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Ticket] Filter for Sheet
2 participants